HxC convert and SAP files.

pulkomandy · **Joined:** Sun Mar 20, 2011 6:55 pm **Posts:** 131

Some SAP files aren't recognised by the HxC converter (linux version). For example the MO5 DOS disk (rather annoying...)
http://www.logicielsmoto.com/download.php?fileid=488

Jeff · **Posted:** Mon Oct 24, 2011 10:18 pm

pulkomandy wrote:

Some SAP files aren't recognised by the HxC converter (linux version). For example the MO5 DOS disk (rather annoying...)
http://www.logicielsmoto.com/download.php?fileid=488

mhh ? works well with the windows version and with the cygwin compiled version.
what is your linux ?

gilles · **Joined:** Sat Jun 18, 2011 11:54 pm **Posts:** 24

@pulko: maybe your patch have a side effect?

pulkomandy · **Joined:** Sun Mar 20, 2011 6:55 pm **Posts:** 131

Running a 64-bit debian "sid".
Linux Akina 3.0.0-1-amd64 #1 SMP Sat Aug 27 16:21:11 UTC 2011 x86_64 GNU/Linux

With gcc 4.6.1.

Reverted the patch to make sure (with a make clean), and I get the same result...
The .fd version from dcmoto.free.fr doesn't work either.

I can provide an ssh access to this computer if you want to test.

pulkomandy · **Joined:** Sun Mar 20, 2011 6:55 pm **Posts:** 131

SAP bug found:

...
strtolower(filepath)
...
sap_openarchive(filepath)

Sorry, but some of my files do have uppercase names.
Solution :
sap_openarchive(imgfile) // the original file name

Also noticed:
instead of using strlen + malloc + sprintf to copy a string, you can use strdup which does it in only one call.

Jeff · **Posted:** Tue Oct 25, 2011 9:32 pm

pulkomandy wrote:

SAP bug found:

...
strtolower(filepath)
...
sap_openarchive(filepath)

Sorry, but some of my files do have uppercase names.
Solution :
sap_openarchive(imgfile) // the original file name

Also noticed:
instead of using strlen + malloc + sprintf to copy a string, you can use strdup which does it in only one call.

oh ok i see

will correct this on the trunk.

Jeff · **Posted:** Tue Oct 25, 2011 10:35 pm

Done !

Thanks for the debug session. (under windows/cygwin the file system isn't case sensitive... :roll:

)

HxC Floppy Drive Emulator

HxC convert and SAP files.

Who is online